-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent * and other things in the same query for Oracle #24631
Merged
nickvergessen
merged 1 commit into
master
from
bugfix/noid/prevent-select-asterix-and-specifics
Dec 14, 2020
Merged
Prevent * and other things in the same query for Oracle #24631
nickvergessen
merged 1 commit into
master
from
bugfix/noid/prevent-select-asterix-and-specifics
Dec 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 362: failuresqliteShow full log
|
rullzer
approved these changes
Dec 10, 2020
Signed-off-by: Joas Schilling <coding@schilljs.com>
dd3bd41
to
5828f3c
Compare
juliushaertl
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅
So I added an error log for queries that select
*
and something else at the same time. Didn't want to go as far as throwing on it. Might consider this in the future, but let's start "soft"