Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UpdateNotification.vue #24633

Merged
merged 1 commit into from Jan 26, 2021
Merged

Update UpdateNotification.vue #24633

merged 1 commit into from Jan 26, 2021

Conversation

jospoortvliet
Copy link
Member

I've updated the text, but the 'learn more about updates and update channels' should link to https://nextcloud.com/release-channels/ and I don't know how to do that ;-)

@skjnldsv
Copy link
Member

Labels? Reviewers?

@StCyr
Copy link
Contributor

StCyr commented Dec 10, 2020

Doesn't the update only shows up after the first minor release or later. only apply to the stable channel?

If so, this sentence shouldn't be displayed when the beta channel is selected

@jospoortvliet
Copy link
Member Author

Doesn't the update only shows up after the first minor release or later. only apply to the stable channel?

If so, this sentence shouldn't be displayed when the beta channel is selected

yeah, we could even note that the beta channel is a quick way to get the release. But I don't want this text to become super long and complicated. I think it is fine this way, to be honest - ppl will get it and they can click the link (to be added) and just check the website.
There I explain it all ;-)

@StCyr
Copy link
Contributor

StCyr commented Dec 10, 2020

Yeah, having the link would definitively be a good thing 👍

@jospoortvliet
Copy link
Member Author

Yeah, having the link would definitively be a good thing

if you know how it works, feel free to suggest how to add the link - I just have no idea how to do this in vue!

@StCyr
Copy link
Contributor

StCyr commented Dec 10, 2020

Ah! This is not a change of the settings/admin/overview page... :-(

@jospoortvliet
Copy link
Member Author

Ah! This is not a change of the settings/admin/overview page... :-(

it is not? That is certainly what I was trying to accomplish! Again, please, if you can do better, please please do. I just can't do this myself, I lack the technical knowledge but what I'm trying to do is improve the text on the admin overview page and add a link.

I mean for the text to change into this:

Note that after a new release the update only shows up after the first minor release or later. We roll out new versions spread out over time to our users and sometimes skip a version when issues are found. Learn more about updates and release channels.

Obviously, the last sentence should link to https://nextcloud.com/release-channels/

Anyone else who can help with this?

@jospoortvliet
Copy link
Member Author

@skjnldsv you can probably do this fairly quickly as I believe you know vue.js a bit... Please? It'd be really nice to have it in 21 :(

@StCyr
Copy link
Contributor

StCyr commented Jan 11, 2021

@skjnldsv you can probably do this fairly quickly as I believe you know vue.js a bit... Please? It'd be really nice to have it in 21 :(

I'm looking at it. I've realized I hadn't re-compile the code prior testing

@StCyr
Copy link
Contributor

StCyr commented Jan 11, 2021

Is it what you want @jospoortvliet ?

image

@StCyr StCyr self-assigned this Jan 12, 2021
@StCyr
Copy link
Contributor

StCyr commented Jan 12, 2021

I don't understand the build failure. Is it related to our changes at all?

@jospoortvliet
Copy link
Member Author

Is it what you want @jospoortvliet ?

image

Thank you and yes, that is it, very nice!

I don't understand the build failure. Is it related to our changes at all?

It says "this is most likely a problem with the node-sass package"...

@jospoortvliet
Copy link
Member Author

@nickvergessen offered to fix it, claiming we broke translations with this ;-)

I've updated the text, but the 'learn more about updates and update channels' should link to https://nextcloud.com/release-channels/
@nickvergessen nickvergessen added this to the Nextcloud 21 milestone Jan 18, 2021
This was referenced Jan 19, 2021
@rullzer rullzer merged commit 7a892a3 into master Jan 26, 2021
@rullzer rullzer deleted the jospoortvliet-patch-1 branch January 26, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants