Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parent::__construct() calls to Jobs #24695

Merged

Conversation

nickvergessen
Copy link
Member

Regression from #24340

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

Found this in my log:

{
  "reqId": "snPXNJw8Fxz6KDpvZ8pO",
  "level": 3,
  "time": "2020-12-14T16:17:09+01:00",
  "remoteAddr": "",
  "user": "--",
  "app": "cron",
  "method": "",
  "url": "--",
  "message": {
    "Exception": "Error",
    "Message": "Call to a member function getTime() on null",
    "Code": 0,
    "Trace": [
      {
        "file": "/home/nickv/Nextcloud/21/server/apps/settings/lib/BackgroundJobs/VerifyUserData.php",
        "line": 104,
        "function": "execute",
        "class": "OCP\\BackgroundJob\\Job",
        "type": "->"
      },
      {
        "file": "/home/nickv/Nextcloud/21/server/cron.php",
        "line": 127,
        "function": "execute",
        "class": "OCA\\Settings\\BackgroundJobs\\VerifyUserData",
        "type": "->"
      }
    ],
    "File": "/home/nickv/Nextcloud/21/server/lib/public/BackgroundJob/Job.php",
    "Line": 78,
    "CustomMessage": "--"
  },
  "userAgent": "--",
  "version": "21.0.0.8"
}

@rullzer rullzer mentioned this pull request Dec 15, 2020
59 tasks
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah shit right...

@rullzer
Copy link
Member

rullzer commented Dec 15, 2020

Linter says no

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 15, 2020
@nickvergessen nickvergessen merged commit e196cc0 into master Dec 15, 2020
@nickvergessen nickvergessen deleted the bugfix/24340/fix-missing-parent-constructor-calls branch December 15, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants