Log an error when setting a custom header on "Not Modified" responses

[nickvergessen]

https://stackoverflow.com/a/17822709

Quoting from section 10.3.5 of RFC 2616:

If the conditional GET used a strong cache validator, the response SHOULD NOT include other entity-headers. Otherwise (i.e., the conditional GET used a weak validator), the response MUST NOT include other entity-headers; this prevents inconsistencies between cached entity-bodies and updated headers.

Apache is stripping them out anyway, so logging them as error for developing instances.

[ChristophWurst]

Good 2 know

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 487: failure

mariadb10.1-php7.3

Show full log

There was 1 error:

1) Test\SystemTag\SystemTagManagerTest::testUpdateTag with data set #2 (array('one', false, false), array('one', true, true))
OCP\SystemTag\TagNotFoundException: Tag does not exist

/drone/src/lib/private/SystemTag/SystemTagManager.php:238
/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:346

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mysql5.6-php7.3

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\Share20\DefaultShareProviderTest::testGetAllShares
Failed asserting that '155' matches expected 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2922