[stable19] LDAP: fix inGroup for memberUid type of group memberships #24739

tofuSCHNITZEL · 2020-12-17T00:32:55Z

backport for stable19 of #24402

Signed-off-by: Tobias Perschon <tobias@perschon.at>

- the type check is not necessary anymore for the return type of _groupMembers() Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

Signed-off-by: Tobias Perschon <tobias@perschon.at>

faily-bot · 2020-12-17T01:01:38Z

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 557: failure

sqlite

Show full log

There was 1 error:

1) OCA\User_LDAP\Tests\Group_LDAPTest::testCountEmptySearchString
TypeError: Argument 1 passed to Mock_Access_134dd683::fetchListOfUsers() must be of the type string, null given, called in /drone/src/apps/user_ldap/lib/Group_LDAP.php on line 262

/drone/src/apps/user_ldap/lib/Group_LDAP.php:262
/drone/src/apps/user_ldap/lib/Group_LDAP.php:1012
/drone/src/apps/user_ldap/tests/Group_LDAPTest.php:87

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

mariadb10.1-php7.2

Show full log

There was 1 error:

1) OCA\User_LDAP\Tests\Group_LDAPTest::testCountEmptySearchString
TypeError: Argument 1 passed to Mock_Access_02d72d03::fetchListOfUsers() must be of the type string, null given, called in /drone/src/apps/user_ldap/lib/Group_LDAP.php on line 262

/drone/src/apps/user_ldap/lib/Group_LDAP.php:262
/drone/src/apps/user_ldap/lib/Group_LDAP.php:1012
/drone/src/apps/user_ldap/tests/Group_LDAPTest.php:87

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

mariadb10.4-php7.3

Show full log

There was 1 error:

1) OCA\User_LDAP\Tests\Group_LDAPTest::testCountEmptySearchString
TypeError: Argument 1 passed to Mock_Access_ab819b5f::fetchListOfUsers() must be of the type string, null given, called in /drone/src/apps/user_ldap/lib/Group_LDAP.php on line 262

/drone/src/apps/user_ldap/lib/Group_LDAP.php:262
/drone/src/apps/user_ldap/lib/Group_LDAP.php:1012
/drone/src/apps/user_ldap/tests/Group_LDAPTest.php:87

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

mysql8.0-php7.2

Show full log

There was 1 error:

1) OCA\User_LDAP\Tests\Group_LDAPTest::testCountEmptySearchString
TypeError: Argument 1 passed to Mock_Access_13f994b6::fetchListOfUsers() must be of the type string, null given, called in /drone/src/apps/user_ldap/lib/Group_LDAP.php on line 262

/drone/src/apps/user_ldap/lib/Group_LDAP.php:262
/drone/src/apps/user_ldap/lib/Group_LDAP.php:1012
/drone/src/apps/user_ldap/tests/Group_LDAPTest.php:87

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

mysql5.6-php7.2

Show full log

There was 1 error:

1) OCA\User_LDAP\Tests\Group_LDAPTest::testCountEmptySearchString
TypeError: Argument 1 passed to Mock_Access_e03687da::fetchListOfUsers() must be of the type string, null given, called in /drone/src/apps/user_ldap/lib/Group_LDAP.php on line 262

/drone/src/apps/user_ldap/lib/Group_LDAP.php:262
/drone/src/apps/user_ldap/lib/Group_LDAP.php:1012
/drone/src/apps/user_ldap/tests/Group_LDAPTest.php:87

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

postgres9-php7.3

Show full log

There was 1 error:

1) OCA\User_LDAP\Tests\Group_LDAPTest::testCountEmptySearchString
TypeError: Argument 1 passed to Mock_Access_5005fb4a::fetchListOfUsers() must be of the type string, null given, called in /drone/src/apps/user_ldap/lib/Group_LDAP.php on line 262

/drone/src/apps/user_ldap/lib/Group_LDAP.php:262
/drone/src/apps/user_ldap/lib/Group_LDAP.php:1012
/drone/src/apps/user_ldap/tests/Group_LDAPTest.php:87

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

postgres11-php7.2

Show full log

There was 1 error:

1) OCA\User_LDAP\Tests\Group_LDAPTest::testCountEmptySearchString
TypeError: Argument 1 passed to Mock_Access_b159d878::fetchListOfUsers() must be of the type string, null given, called in /drone/src/apps/user_ldap/lib/Group_LDAP.php on line 262

/drone/src/apps/user_ldap/lib/Group_LDAP.php:262
/drone/src/apps/user_ldap/lib/Group_LDAP.php:1012
/drone/src/apps/user_ldap/tests/Group_LDAPTest.php:87

--

There were 3 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

3) OCA\Files_Sharing\Tests\External\ManagerTest::testAddShare
Cannot stub or mock class or interface "OCA\Files_Sharing\Tests\External\IManager" which does not exist

tofuSCHNITZEL · 2020-12-17T11:51:22Z

Status of 557: failure

@blizzz to the rescue - I don't really understand whats going on ;) also it seems to affect the files_sharing app not LDAP?

blizzz · 2020-12-17T12:05:08Z

Status of 557: failure

@blizzz to the rescue - I don't really understand whats going on ;) also it seems to affect the files_sharing app not LDAP?

I believe we have here an older phpunit running. The newer one makes the mocks return an empty value based on the return type hint, e.g. an empty array for arrays. The older runs just returns null. So the mocks in the tests needs to be adjusted and any important method that is call has to be made to return what is expected later on.

tofuSCHNITZEL · 2021-02-06T15:41:14Z

I fear I don't understand enough about these tests to fix this....

DanScharon · 2021-02-23T15:56:08Z

any chance to get this backport into 19?

MichaIng · 2021-07-06T17:51:09Z

I mark this as closed, as Nextcloud 19 won't get any further releases.

EDIT ... oh, don't be sad @backportbot-nextcloud 😄.

blizzz and others added 6 commits December 17, 2020 01:08

flatten result array as expected by following code

ed65fd1

Signed-off-by: Tobias Perschon <tobias@perschon.at>

moved the array_reduce to fix large search case

c399493

Signed-off-by: Tobias Perschon <tobias@perschon.at>

use faster and less hungry foreach

bada6d1

Signed-off-by: Tobias Perschon <tobias@perschon.at>

check number of members after potential resolving of rdns

e2fea62

- the type check is not necessary anymore for the return type of _groupMembers() Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

add unit tests

c9cb14e

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>

php-cs happyness

957f634

Signed-off-by: Tobias Perschon <tobias@perschon.at>

tofuSCHNITZEL requested a review from blizzz December 17, 2020 00:32

tofuSCHNITZEL changed the title ~~Backport/24402/stable19~~ backport - LDAP: fix inGroup for memberUid type of group memberships Dec 17, 2020

blizzz changed the title ~~backport - LDAP: fix inGroup for memberUid type of group memberships~~ [stable19] LDAP: fix inGroup for memberUid type of group memberships Dec 17, 2020

MichaIng closed this Jul 6, 2021

MichaIng deleted the backport/24402/stable19 branch July 6, 2021 17:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[stable19] LDAP: fix inGroup for memberUid type of group memberships #24739

[stable19] LDAP: fix inGroup for memberUid type of group memberships #24739

tofuSCHNITZEL commented Dec 17, 2020

faily-bot bot commented Dec 17, 2020

tofuSCHNITZEL commented Dec 17, 2020

Status of 557: failure

blizzz commented Dec 17, 2020

Status of 557: failure

tofuSCHNITZEL commented Feb 6, 2021

DanScharon commented Feb 23, 2021

MichaIng commented Jul 6, 2021 •

edited

[stable19] LDAP: fix inGroup for memberUid type of group memberships #24739

[stable19] LDAP: fix inGroup for memberUid type of group memberships #24739

Conversation

tofuSCHNITZEL commented Dec 17, 2020

faily-bot bot commented Dec 17, 2020

Status of 557: failure

sqlite

mariadb10.1-php7.2

mariadb10.4-php7.3

mysql8.0-php7.2

mysql5.6-php7.2

postgres9-php7.3

postgres11-php7.2

tofuSCHNITZEL commented Dec 17, 2020

Status of 557: failure

blizzz commented Dec 17, 2020

Status of 557: failure

tofuSCHNITZEL commented Feb 6, 2021

DanScharon commented Feb 23, 2021

MichaIng commented Jul 6, 2021 • edited

MichaIng commented Jul 6, 2021 •

edited