Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ext-zip as platform dependency #24835

Merged
merged 1 commit into from
May 3, 2021
Merged

Add ext-zip as platform dependency #24835

merged 1 commit into from
May 3, 2021

Conversation

ChristophWurst
Copy link
Member

Discovered while working with \OC\Archive\ZIP.

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Dec 23, 2020
@ChristophWurst ChristophWurst added this to the Nextcloud 22 milestone Dec 23, 2020
@ChristophWurst ChristophWurst self-assigned this Dec 23, 2020
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Dec 23, 2020
Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Dec 28, 2020
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 28, 2020
@ChristophWurst ChristophWurst marked this pull request as ready for review December 28, 2020 10:14
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 28, 2020
This was referenced Dec 30, 2020
Merged
Merged
@rullzer rullzer modified the milestones: Nextcloud 21, Nextcloud 22 Jan 6, 2021
@ChristophWurst ChristophWurst mentioned this pull request Feb 9, 2021
Closed
@ChristophWurst
Copy link
Member Author

Reported upsteam that the psalm action doesn't work with this: psalm/psalm-github-actions#27

@faily-bot
Copy link

faily-bot bot commented Feb 9, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 2057: failure

checkers

@kesselb kesselb added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Mar 10, 2021
@J0WI
Copy link
Contributor

J0WI commented Apr 28, 2021

PCNTL is also missing

@ChristophWurst ChristophWurst removed the 2. developing Work in progress label Apr 30, 2021
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Apr 30, 2021
@ChristophWurst
Add ext-zip as platform dependency
ab3424a 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 3, 2021
@ChristophWurst ChristophWurst merged commit 7c3f833 into master May 3, 2021
Christoph's Tasks automation moved this from TO INTEGRATE to DONE May 3, 2021
@ChristophWurst ChristophWurst deleted the enhancement/composer-ext-zip branch May 3, 2021 11:29
@ChristophWurst
Copy link
Member Author

PCNTL is also missing

It's optional, though https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html

@come-nc come-nc mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@kesselb kesselb kesselb approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
No open projects
Christoph's Tasks
DONE
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ChristophWurst @J0WI @rullzer @kesselb