Also include external share results in recommendations

[juliushaertl]

Include external share results in recommendations if condition matches

The use case for this is that deck can add a default result which will always be shown in order to not mess the share result list with too many entries.

[rullzer]

sure...

[faily-bot]

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 845: failure

nodb

Show full log

There were 5 errors:

1) OCA\DAV\Tests\Command\MoveCalendarTest::testMove
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:214

2) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationNotPartOfGroup with data set #1 (false)
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:269

3) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationPartOfGroup
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:312

4) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationNotPartOfGroupAndForce
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:358

5) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithCalendarAlreadySharedToDestination with data set #0 (true)
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:421

--

There were 11 warnings:

1) Test\AppFramework\Controller\AuthPublicShareControllerTest::testAuthenticateAuthenticated
Trying to configure method "isAuthenticated" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

6) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set

7) Warning
The data provider specified for ExpirationTest::testGetMaxAgeAsTimestamp is invalid.
PHPUnit\Util\Exception: Method timestampTestData does not exist

8) OCA\Settings\Tests\Mailer\NewUserMailHelperTest::testGenerateTemplateWithPasswordResetToken
Method getTime may not return value of type string, its return declaration is ": int"

9) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_6ce04dd0, its return declaration is ": void"

10) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_8f6ee36b, its return declaration is ": void"

11) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_8f6ee36b, its return declaration is ": void"

--

There were 6 failures:

1) OCA\DAV\Tests\Command\MoveCalendarTest::testWithBadUserOrigin with data set #0 (false, true)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:121
.

2) OCA\DAV\Tests\Command\MoveCalendarTest::testWithBadUserOrigin with data set #1 (true, false)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:121
.

3) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithInexistantCalendar
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:146
.

4) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithExistingDestinationCalendar
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:181
.

5) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationNotPartOfGroup with data set #0 (true)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:269
.

6) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithCalendarAlreadySharedToDestination with data set #1 (false)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:421
.

mariadb10.4-php7.4

Show full log

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125