Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch no current user when adding someone to a group #24906

Closed
wants to merge 1 commit into from
Closed

Catch no current user when adding someone to a group #24906

wants to merge 1 commit into from

Conversation

ChristophWurst
Copy link
Member

馃悩

Catches an exception when occ group:adduser is run

@ChristophWurst
Catch no current user when adding someone to a group
39dbbf5 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 21 milestone Dec 30, 2020
@ChristophWurst ChristophWurst self-assigned this Dec 30, 2020
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Dec 30, 2020
@rullzer rullzer mentioned this pull request Dec 30, 2020
Closed
@faily-bot
Copy link

faily-bot bot commented Dec 30, 2020

馃 beep boop beep 馃

Here are the logs for the failed build:

Status of 862: failure

checkers

nodb

Show full log 
There were 5 errors:

1) OCA\DAV\Tests\Command\MoveCalendarTest::testMove
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:214

2) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationNotPartOfGroup with data set #1 (false)
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:269

3) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationPartOfGroup
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:312

4) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationNotPartOfGroupAndForce
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:358

5) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithCalendarAlreadySharedToDestination with data set #0 (true)
Error: Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found

/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:421

--

There were 11 warnings:

1) Test\AppFramework\Controller\AuthPublicShareControllerTest::testAuthenticateAuthenticated
Trying to configure method "isAuthenticated" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #0 (35, 15, 2, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

3) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #1 (35, 45, 15, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

4) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #2 (35, 45, 5, true)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

5) Test\Support\Subscription\RegistryTest::testDelegateIsHardUserLimitReachedWithoutSupportAppAndUserCount with data set #3 (35, 45, 55, false)
Cannot stub or mock class or interface "Test\Support\Subscription\UserInterface" which does not exist

6) OCA\DAV\Tests\unit\CalDAV\CalendarTest::testConfidentialClassification with data set #0 (3, false)
No method rule is set

7) Warning
The data provider specified for ExpirationTest::testGetMaxAgeAsTimestamp is invalid.
PHPUnit\Util\Exception: Method timestampTestData does not exist

8) OCA\Settings\Tests\Mailer\NewUserMailHelperTest::testGenerateTemplateWithPasswordResetToken
Method getTime may not return value of type string, its return declaration is ": int"

9) OCA\TwoFactorBackupCodes\Tests\Unit\Listener\ActivityPublisherTest::testHandleCodesGeneratedEvent
Method publish may not return value of type Mock_IEvent_4b7b11dc, its return declaration is ": void"

10) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #1 ('app2', '1.0.1', '1.0.0', '1.0.0', true, array('user1'), array(array('user1')))
Method notify may not return value of type Mock_INotification_b73d8031, its return declaration is ": void"

11) OCA\UpdateNotification\Tests\Notification\BackgroundJobTest::testCreateNotifications with data set #2 ('app3', '1.0.1', false, false, true, array('user2', 'user3'), array(array('user2'), array('user3')))
Method notify may not return value of type Mock_INotification_b73d8031, its return declaration is ": void"

--

There were 6 failures:

1) OCA\DAV\Tests\Command\MoveCalendarTest::testWithBadUserOrigin with data set #0 (false, true)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:121
.

2) OCA\DAV\Tests\Command\MoveCalendarTest::testWithBadUserOrigin with data set #1 (true, false)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:121
.

3) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithInexistantCalendar
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:146
.

4) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithExistingDestinationCalendar
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:181
.

5) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithDestinationNotPartOfGroup with data set #0 (true)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:269
.

6) OCA\DAV\Tests\Command\MoveCalendarTest::testMoveWithCalendarAlreadySharedToDestination with data set #1 (false)
Failed asserting that exception of type "Error" matches expected exception "InvalidArgumentException". Message was: "Class 'Symfony\Component\Console\Output\TrimmedBufferOutput' not found" at
/drone/src/3rdparty/symfony/console/Style/SymfonyStyle.php:49
/drone/src/apps/dav/lib/Command/MoveCalendar.php:114
/drone/src/3rdparty/symfony/console/Command/Command.php:255
/drone/src/3rdparty/symfony/console/Tester/CommandTester.php:76
/drone/src/apps/dav/tests/unit/Command/MoveCalendarTest.php:421
.

mysql8.0-php7.4

Show full log 
There were 3 errors:

1) OCA\Files_Sharing\Tests\ApiTest::testShareStorageMountPoint
OCP\Files\StorageNotAvailableException: File with id "5563" has not been found.

/drone/src/lib/private/Files/Storage/FailedStorage.php:114
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1168
/drone/src/lib/private/Files/View.php:544
/drone/src/apps/files_sharing/tests/ApiTest.php:1254

Caused by
OCP\Files\NotFoundException: File with id "5563" has not been found.

/drone/src/lib/private/Files/View.php:1769
/drone/src/apps/files_sharing/lib/SharedStorage.php:130
/drone/src/apps/files_sharing/lib/SharedStorage.php:487
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1168
/drone/src/lib/private/Files/View.php:544
/drone/src/apps/files_sharing/tests/ApiTest.php:1254

2) OCA\Files_Sharing\Tests\ApiTest::testInvisibleSharesUser
OCP\Files\StorageNotAvailableException: File with id "5653" has not been found.

/drone/src/lib/private/Files/Storage/FailedStorage.php:114
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1341
/drone/src/lib/private/Files/View.php:1390
/drone/src/lib/private/Files/Node/Root.php:201
/drone/src/lib/private/Files/Node/Folder.php:140
/drone/src/apps/files_sharing/lib/Controller/ShareAPIController.php:466
/drone/src/apps/files_sharing/tests/ApiTest.php:1406

Caused by
OCP\Files\NotFoundException: File with id "5653" has not been found.

/drone/src/lib/private/Files/View.php:1769
/drone/src/apps/files_sharing/lib/SharedStorage.php:130
/drone/src/apps/files_sharing/lib/SharedStorage.php:487
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1341
/drone/src/lib/private/Files/View.php:1390
/drone/src/lib/private/Files/Node/Root.php:201
/drone/src/lib/private/Files/Node/Folder.php:140
/drone/src/apps/files_sharing/lib/Controller/ShareAPIController.php:466
/drone/src/apps/files_sharing/tests/ApiTest.php:1406

3) OCA\Files_Sharing\Tests\ApiTest::testInvisibleSharesGroup
OCP\Files\StorageNotAvailableException: File with id "5672" has not been found.

/drone/src/lib/private/Files/Storage/FailedStorage.php:114
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1341
/drone/src/lib/private/Files/View.php:1390
/drone/src/lib/private/Files/Node/Root.php:201
/drone/src/lib/private/Files/Node/Folder.php:140
/drone/src/apps/files_sharing/lib/Controller/ShareAPIController.php:466
/drone/src/apps/files_sharing/tests/ApiTest.php:1440

Caused by
OCP\Files\NotFoundException: File with id "5672" has not been found.

/drone/src/lib/private/Files/View.php:1769
/drone/src/apps/files_sharing/lib/SharedStorage.php:130
/drone/src/apps/files_sharing/lib/SharedStorage.php:487
/drone/src/lib/private/Files/Storage/Wrapper/Jail.php:235
/drone/src/lib/private/Files/View.php:1341
/drone/src/lib/private/Files/View.php:1390
/drone/src/lib/private/Files/Node/Root.php:201
/drone/src/lib/private/Files/Node/Folder.php:140
/drone/src/apps/files_sharing/lib/Controller/ShareAPIController.php:466
/drone/src/apps/files_sharing/tests/ApiTest.php:1440

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\SystemTag\SystemTagManagerTest::testGetAllTags with data set #1 (array(array('one', false, false), array('two', false, false)))
Failed asserting that false is true.

/drone/src/tests/lib/SystemTag/SystemTagManagerTest.php:122

This was referenced Dec 30, 2020
Merged
Merged
@nickvergessen
Copy link
Member

Replaced by nextcloud/activity#541

Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to DONE Jan 5, 2021
@nickvergessen nickvergessen deleted the fix/add-user-to-group-no-current-user branch January 5, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug feature: users and groups
Projects
No open projects
Christoph's Tasks
DONE
Milestone
Nextcloud 21
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChristophWurst @nickvergessen