Dismiss reminder notifications from passed events #25114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
added
3. to review
nickvergessen
approved these changes
Jan 13, 2021
ChristophWurst
approved these changes
Jan 13, 2021
|
Would it not make sense to just take the end time of the event as when to dismiss them? |
I thought it could cause trouble with events ongoing for several days for instance, but in most cases it may be more appropriate, so I think you're right. |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld
force-pushed
the
dismiss-reminder-notifications-from-passed-events
branch
from
c76aa78
to
536e157
Compare
rullzer
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder notifications are now dismissed after the event ends.
I've given a 10 minutes grace period (so that you still see the notification if you are late for an event) but we can configure/remove this.Closes #25111