Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @nextcloud/vue imports #25131

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Fix @nextcloud/vue imports #25131

merged 1 commit into from
Jan 14, 2021

Conversation

skjnldsv
Copy link
Member

Reduce the size by a lot!

Hash: de4f1b92c36390c99e86
Version: webpack 4.45.0
Time: 5384ms
Built at: 2021-01-14 17:10:46
           Asset      Size  Chunks                   Chunk Names
    dashboard.js  3.35 MiB    main  [emitted]        main
dashboard.js.map   3.3 MiB    main  [emitted] [dev]  main
Entrypoint main = dashboard.js dashboard.js.map

--- VS ---

Hash: 40bbdf3197497f22f601
Version: webpack 4.45.0
Time: 460ms
Built at: 2021-01-14 17:10:59
           Asset      Size  Chunks                   Chunk Names
    dashboard.js  1.51 MiB    main  [emitted]        main
dashboard.js.map  1.62 MiB    main  [emitted] [dev]  main
Entrypoint main = dashboard.js dashboard.js.map

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💨

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 14, 2021
@rullzer rullzer merged commit 801c691 into master Jan 14, 2021
@rullzer rullzer deleted the fix/imports branch January 14, 2021 18:08
@rullzer rullzer mentioned this pull request Jan 15, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants