Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "composer.lock" for acceptance tests to git #25176

Merged
merged 1 commit into from
Jan 18, 2021

Conversation

danxuliu
Copy link
Member

As "composer.lock" was not versioned the dependencies had to be resolved everytime that the acceptance tests run, which took some precious time*.

Besides that the dependency versions were also tightened for better control.

*Apparently up to eleven minutes (Updating dependencies (including require-dev) at 5s, next log at 670s 馃槺) so I think that deserves a backport.

As "composer.lock" was not versioned the dependencies had to be resolved
everytime that the acceptance tests run, which took some precious time.

Besides that the dependency versions were also tightened for better
control.

Signed-off-by: Daniel Calvi帽o S谩nchez <danxuliu@gmail.com>
@danxuliu danxuliu added bug 3. to review Waiting for reviews labels Jan 18, 2021
@danxuliu danxuliu added this to the Nextcloud 21 milestone Jan 18, 2021
@danxuliu
Copy link
Member Author

/backport to stable20

@danxuliu
Copy link
Member Author

/backport to stable19

@faily-bot
Copy link

faily-bot bot commented Jan 18, 2021

馃 beep boop beep 馃

Here are the logs for the failed build:

Status of 1419: failure

mariadb10.4-php7.4

Show full log
There was 1 warning:

1) Test\Security\CredentialsManagerTest::testRetrieve
Trying to configure method "fetch" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

@MorrisJobke
Copy link
Member

Nice finding!

Bildschirmfoto 2021-01-18 um 12 47 58

@MorrisJobke
Copy link
Member

BTW: this went from 7h 5m 24s to 5h 0m 51s. So it reduced the time of our CI pipeline by 30%.

@rullzer rullzer mentioned this pull request Jan 19, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants