Directly add notifications element #25184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since there seems to be an issue with the old way notifications is mounted, we now hardcode it. Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added a commit
to nextcloud/notifications
that referenced
this pull request
Jan 18, 2021
Based on nextcloud/server#25184 Signed-off-by: Joas Schilling <coding@schilljs.com>
1 task
|
The error is because the notifications PR nextcloud/notifications#840 is not in. |
skjnldsv
approved these changes
Jan 18, 2021
restarted tests |
npmbuildbot-nextcloud bot
pushed a commit
to nextcloud/notifications
that referenced
this pull request
Jan 19, 2021
Based on nextcloud/server#25184 Signed-off-by: Joas Schilling <coding@schilljs.com> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there seems to be an issue with the old way notifications is mounted,
we now hardcode it as suggested by @skjnldsv