Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance markdown file preview rendering #25212

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Jan 19, 2021

This PR tries to apply some sort of styling to markdown previews (mainly giving the headers a different size) and remove markdown symbols that we currently cannot render. This should give the user a bit of an overview how the file is structured.

  • Remove markdown symbols that we cannot render (bold/italic/strikethrough/links)
  • 4-byte characters are removed since imagettftext is unable to render them even with a ttf font that includes symbols for that, i also gave pango rendering with imagemagick a try for that but none seem to work properly unfortunately

Feedback from @jancborchardt

  • Bold headlines
  • more space above the headings but less below

image

image

@rullzer rullzer added this to the Nextcloud 21 milestone Jan 20, 2021
@juliushaertl juliushaertl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 20, 2021
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is waiting for the first report that it doesn't look exactly like the editor. But so be it I guess :)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke merged commit 4c81f5c into master Jan 20, 2021
@MorrisJobke MorrisJobke deleted the enh/preview-markdown branch January 20, 2021 14:02
@rullzer rullzer mentioned this pull request Jan 21, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants