Added 301 redirect for favicon.ico #25307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirect /favicon.ico to /core/img/favicon.ico Signed-off-by: Elsie Hupp <github@elsiehupp.com>
elsiehupp
force-pushed
the
redirect-301-favicon-ico
branch
from
8c09208
to
97c6c1d
Compare
|
This is what I have in Apache today, so it works the same way i believe. |
|
Thanks for the pull request. A request to favicon.ico is redirected to login with the default configuration. I guess something is wrong with the server configuration. This change is out of scope for nextcloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #24821.
I haven't been able to test it, yet.