add repair job for unencoded group share uris #25393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable20 |
|
/backport to stable19 |
blizzz
force-pushed
the
fix/25165/repair-dav-shares
branch
from
2fd34ca
to
fc61990
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/25165/repair-dav-shares
branch
from
fc61990
to
bd8b431
Compare
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
/backport to stable21 |
rullzer
approved these changes
Feb 2, 2021
This was referenced Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25165
the test file shows the scenarios: we try to detect uris that are not encoded and encoding would for sure they that they would match an existing group.
A side effect I found: if an old broken share was present next to a new valid share, it would be updated successfully despite the UNIQUE index on Postgres, because PostgreSQL consider NULL columns not equal in this case. Hence, the second commit that introduces the grouping by both selected columns.→ https://www.postgresql.org/docs/current/ddl-constraints.html#DDL-CONSTRAINTS-UNIQUE-CONSTRAINTS