-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable20] Fix duplicate tag info view registration #25477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b97214f
to
227d474
Compare
I've rebuilt the assets with For some reason it wanted to delete the same files like in #25475 (comment). Here I only committed the systemtags assets. |
I've raised #25491 to look into the failed sharing acceptance test as it seems to happen consistently on stable20. |
Merged
Only register the tag info view once as it's stored in a singleton. This fixes an issue where the tag info view did not get rendered after swiching between different file views. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
227d474
to
1936895
Compare
rebased to get CI green |
rullzer
approved these changes
Feb 5, 2021
ChristophWurst
approved these changes
Feb 5, 2021
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 1962: failureacceptance-header
Show full log
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #25441