Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Fix duplicate tag info view registration #25477

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 4, 2021

⚠️ This backport had conflicts and is incomplete ⚠️

backport of #25441

@PVince81
Copy link
Member

PVince81 commented Feb 4, 2021

I've rebuilt the assets with make dev-setup && make build-js-production.

For some reason it wanted to delete the same files like in #25475 (comment).

Here I only committed the systemtags assets.

@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

I've raised #25491 to look into the failed sharing acceptance test as it seems to happen consistently on stable20.

@rullzer rullzer mentioned this pull request Feb 5, 2021
@rullzer rullzer added the 3. to review Waiting for reviews label Feb 5, 2021
Only register the tag info view once as it's stored in a singleton.
This fixes an issue where the tag info view did not get rendered after
swiching between different file views.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member

PVince81 commented Feb 5, 2021

rebased to get CI green

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 5, 2021
@faily-bot
Copy link

faily-bot bot commented Feb 5, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1962: failure

acceptance-header

  • tests/acceptance/features/header.feature:33
Show full log
  Scenario: users from other groups are not seen in the contacts menu when autocompletion is restricted within the same group # /drone/src/tests/acceptance/features/header.feature:33
    Given I am logged in as the admin                                                                                         # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I visit the settings page                                                                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section of the "Administration" group                                                            # AppNavigationContext::iOpenTheSectionOf()
    And I enable restricting username autocompletion to groups                                                                # SettingsContext::iEnableRestrictingUsernameAutocompletionToGroups()
    And I see that username autocompletion is restricted to groups                                                            # SettingsContext::iSeeThatUsernameAutocompletionIsRestrictedToGroups()
    When I open the Contacts menu                                                                                             # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                                                                                # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()
      Failed asserting that true is false.
    And I see that the contact "admin" in the Contacts menu is not shown                                                      # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

@rullzer rullzer merged commit 4717aeb into stable20 Feb 5, 2021
@rullzer rullzer deleted the backport/25441/stable20 branch February 5, 2021 12:21
@rullzer rullzer mentioned this pull request Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants