Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Remove stray compiled assets #25480

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Feb 4, 2021

This was automatically deleted and not regenerated by:
make dev-setup && make build-js-production

I ran those on stable20 and committed the result.

I didn't see this happen on stable21 or master, so probably it's assets that exist since a while and were never properly deleted.
Also: CI did not complain about those missing.

Removing these will avoid devs to be confused like I was in #25475 especially when changing seemingly related files.

This was automatically deleted and not regenerated by:
make dev-setup && make build-js-production

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81
Copy link
Member Author

PVince81 commented Feb 4, 2021

I've had a quick test of the users page and it seemed to work fine. The matching acceptance tests will also confirm this.

@PVince81
Copy link
Member Author

PVince81 commented Feb 5, 2021

restarted CI for hopefully slightly greener results

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do the same in another PR

@juliushaertl
Copy link
Member

Yes, the settings chunk names are chaning on every build update so they maybe a not cleaned up build has made it to the base branch.

@juliushaertl
Copy link
Member

Actually we should have #24865 for stable20 as well

@faily-bot
Copy link

faily-bot bot commented Feb 5, 2021

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 1950: failure

acceptance-app-files-sharing

  • tests/acceptance/features/app-files-sharing.feature:23
Show full log
  Scenario: share a file with another user that needs to accept shares        # /drone/src/tests/acceptance/features/app-files-sharing.feature:23
    Given I act as John                                                       # ActorContext::iActAs()
    And I am logged in as the admin                                           # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I am logged in                                                        # LoginPageContext::iAmLoggedIn()
    And I visit the settings page                                             # SettingsMenuContext::iVisitTheSettingsPage()
    And I open the "Sharing" section                                          # AppNavigationContext::iOpenTheSection()
    And I disable accepting the shares by default                             # SettingsContext::iDisableAcceptingTheSharesByDefault()
    And I see that shares are not accepted by default                         # SettingsContext::iSeeThatSharesAreNotAcceptedByDefault()
    And I act as John                                                         # ActorContext::iActAs()
    And I rename "welcome.txt" to "farewell.txt"                              # FileListContext::iRenameTo()
    And I see that the file list contains a file named "farewell.txt"         # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I share "farewell.txt" with "user0"                                  # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                            # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                         # ActorContext::iActAs()
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    And I see that the file list does not contain a file named "farewell.txt" # FileListContext::iSeeThatTheFileListDoesNotContainAFileNamed()
    And I accept the share for "/farewell.txt" in the notifications           # NotificationsContext::iAcceptTheShareForInTheNotifications()
      Notifications button in the header could not be found after 100 seconds (NoSuchElementException)
    And I open the Files app                                                  # FilesAppContext::iOpenTheFilesApp()
    Then I see that the file list contains a file named "farewell.txt"        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the details view for "farewell.txt"                            # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                   # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                          # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I see that the file is shared with me by "admin"                      # FilesAppSharingContext::iSeeThatTheFileIsSharedWithMeBy()

@PVince81
Copy link
Member Author

PVince81 commented Feb 5, 2021

failures seem unrelated: both in acceptance tests for sharing
and one failure is the DB coverage that got killed...

@PVince81
Copy link
Member Author

PVince81 commented Feb 5, 2021

I've raised #25491 to look into the failed sharing acceptance test as it seems to happen consistently on stable20.

@rullzer rullzer merged commit c781beb into stable20 Feb 5, 2021
@rullzer rullzer deleted the stable20-stray-asset-deletion branch February 5, 2021 10:01
@rullzer rullzer added this to the Nextcloud 20.0.8 milestone Feb 5, 2021
@PVince81
Copy link
Member Author

PVince81 commented Feb 5, 2021

Actually we should have #24865 for stable20 as well

here we go #25504

This was referenced Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants