SVG-logo not displaying in emails due to wrong useSvg flag in html src-code #25984
Labels
0. Needs triage
Pending check for reproducibility or if it fits our roadmap
bug
needs info
stale
Ticket or PR with no recent activity
How to use GitHub
Steps to reproduce
src="https://www.yourdomain.tld/apps/theming/image/logo?useSvg=0&v=11"
Now I can change this code in developer view of a browser easily, but this needs off course be done on the server side. I'm guessing there is a part of the server-code that handles the emails that doesn't properly check the extension of the logo-files used and/or sets the wrong flag.
If someone can point me in the right direction on how to fix it, I can try to fix it and make my first contribution to Nextcloud :) Thanks!
Edit:
My first guess would be that the problem arises from the following code:
$logoUrl = $this->urlGenerator->getAbsoluteURL($this->themingDefaults->getLogo(false));
in the file server/lib/private/Mail/EMailTemplate.php
To me it seems (but I do not fully understand the workings of the code), that the problem is getLogo(false) instead of getLogo().
Why does it state false? Compatibility with older email systems that do not support svg?
Server configuration
Operating system:
Ubuntu 20.04 LTS
Web server:
Apache
Database:
MariaDB 10.3
PHP version:
7.4
Nextcloud version: (see Nextcloud admin page)
20.0.7.1 (but has been the case since version 15 or so)
Updated from an older Nextcloud/ownCloud or fresh install:
Updated
The text was updated successfully, but these errors were encountered: