Download a file in a subfolder in a sharedlink is not working #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the $node created using the path (GET) parameter is not used when executing fileListDownloaded()
|
@daita, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @rullzer and @LukasReschke to be potential reviewers. |
|
cc @rullzer Thoughts? |
|
Can reproduce. |
LukasReschke
requested review from
rullzer,
LukasReschke,
blizzz and
schiessle
|
Tested and works, I can also see why this is needed. At the moment I don't have a better idea how to solve it.... so 👍 |
schiessle
approved these changes
Dec 12, 2016
blizzz
reviewed
Dec 12, 2016
LukasReschke
added a commit
that referenced
this pull request
Dec 12, 2016
For #2615 Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
LukasReschke
requested changes
Dec 12, 2016
| @@ -542,9 +542,9 @@ public function downloadShare($token, $files = null, $path = '', $downloadStartS | |||
| * @param Share\IShare $share | |||
| * @param array $files_list | |||
| */ | |||
Signed-off-by: Maxence Lange <maxence@pontapreta.net>
|
With regard to #2615 (review) the hook is caught by the auditing app only (within the Nextcloud org on Github), but uses the node type. Probably it's OK to continue with the fix as is and if necessary adjust for 11.0.1. Along with a regression test. |
rullzer
approved these changes
Dec 12, 2016
LukasReschke
approved these changes
Dec 12, 2016
LukasReschke
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloading a file in a subfolder returns a 404.
The $node created using the path (GET) parameter is not used when executing fileListDownloaded()