Inject the repair job only once #26834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we backproted we should do a better check. Else we run the code again for everybody upgrading to 22. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
| @@ -53,7 +53,8 @@ private function shouldRun(): bool { | |||
| $versionFromBeforeUpdate = $this->config->getSystemValue('version', '0.0.0.0'); | |||
|
|
|||
| // was added to 22.0.0.3 | |||
| return version_compare($versionFromBeforeUpdate, '22.0.0.3', '<'); | |||
| return version_compare($versionFromBeforeUpdate, '22.0.0.3', '<') && | |||
| version_compare($versionFromBeforeUpdate, '22.0.0.0', '>='); | |||
There was a problem hiding this comment.
but then it wont run on any instance tha updates from 21?
There was a problem hiding this comment.
Yep. It should contain as well the versions before the last patch version of 21 to cover those cases as well. 👍
nickvergessen
approved these changes
Apr 30, 2021
LukasReschke
approved these changes
May 18, 2021
MorrisJobke
added
2. developing
|
Ummm the commend wasn't addressed :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we backproted we should do a better check. Else we run the code
again for everybody upgrading to 22.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl