Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VerifyUserData shall use IAccountManager, not private API #26959

Merged
merged 1 commit into from May 12, 2021
Merged

VerifyUserData shall use IAccountManager, not private API #26959

merged 1 commit into from May 12, 2021

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 12, 2021

Another yak shaved for #26866

@blizzz blizzz added 3. to review Waiting for reviews technical debt labels May 12, 2021
@blizzz blizzz added this to the Nextcloud 22 milestone May 12, 2021
@blizzz blizzz force-pushed the techdebt/noid/verifiyuserdata-iaccountmanager branch from ad482d6 to c4ceafd Compare May 12, 2021 10:29
@blizzz
Copy link
Member Author

blizzz commented May 12, 2021 

Run composer run cs:check -- --format=checkstyle | cs2pr
> php-cs-fixer fix --dry-run --diff '--format=checkstyle'
Loaded config default from "/home/runner/work/server/server/.php_cs.dist".
Script php-cs-fixer fix --dry-run --diff handling the cs:check event returned with error code 8
Warning: Found violation(s) of type: class_definition
Warning: Found violation(s) of type: no_unused_imports
Warning: Found violation(s) of type: braces
Error: Process completed with exit code 1.

not happening locally :-/ Also I do not spot unused imports or such.

PVince81
PVince81 approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nickvergessen
nickvergessen approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests that complain?

@blizzz

This comment has been minimized.

Sign in to view
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 12, 2021
@blizzz blizzz force-pushed the techdebt/noid/verifiyuserdata-iaccountmanager branch from c4ceafd to 9977027 Compare May 12, 2021 20:56
@blizzz
VerifyUserData shall use IAccountManager, not private API
9977027 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz merged commit b8b2e79 into master May 12, 2021
@blizzz blizzz deleted the techdebt/noid/verifiyuserdata-iaccountmanager branch May 12, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 PVince81 approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 22
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@blizzz @nickvergessen @PVince81