Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow removing apps with app store disabled #27088

Merged
merged 1 commit into from Jun 2, 2021
Merged

Conversation

gary-kim
Copy link
Member

Fixes #27074

The appFetcher returns an empty array if the app store is disabled for downloading an app so there's no reason for the install path to return differently if the app store is disabled as far as I can tell (feel free to correct me).

Signed-off-by: Gary Kim <gary@garykim.dev>
@gary-kim gary-kim added the 3. to review Waiting for reviews label May 24, 2021
@gary-kim gary-kim added this to the Nextcloud 22 milestone May 24, 2021
@gary-kim gary-kim added the bug label May 24, 2021
@MorrisJobke MorrisJobke mentioned this pull request May 26, 2021
98 tasks
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the check is indeed not reasonable here. 👍 since it's in place at the Fetcher's.

@blizzz blizzz requested a review from skjnldsv June 2, 2021 17:22
@skjnldsv skjnldsv merged commit 949102c into master Jun 2, 2021
@skjnldsv skjnldsv deleted the fix/27074/removing-apps branch June 2, 2021 19:10
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apps can't/aren't removed by occ if appstoreenabled => false
3 participants