fix getTableNamesWithoutPrefix() #27119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status here? :) |
skjnldsv
added
2. developing
|
I think it needs a rebase and a second review |
Merged
|
/rebase |
|
It is ready for reviews @ArtificialOwl ? |
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nextcloud-command
force-pushed
the
bugfix/noid/get-table-names-without-prefix
branch
from
2eab957
to
5fe0407
Compare
Merged
Merged
nickvergessen
deleted the
bugfix/noid/get-table-names-without-prefix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the code, it seems that getTableNamesWithoutPrefix() is not working as expected.
The method getTableNames() from the dbal will returns 'database.prefix_table_name' instead of 'prefix_table_name' making the strpos() condition always invalid.
This fix will make getTableNames() extracting the
databasefrom the list returned by dbal, getTableNamesWithoutPrefix() will use this new list and remove the prefix.The idea is that even getTableNames() should not contains the name of the database.