[downstream] Skip local shares in bkg scan and occ files:scan (#26590) #2745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @MorrisJobke and @LukasReschke to be potential reviewers. |
icewind1991
requested changes
Dec 19, 2016
| } | ||
|
|
||
| // don't scan received local shares, these can be scanned when scanning the owner's storage | ||
| if ($storage->instanceOfStorage('OCA\Files_Sharing\ISharedStorage')) { |
There was a problem hiding this comment.
Should be 'OCA\Files_Sharing\SharedStorage' else it will also exclude federated shares
icewind1991
approved these changes
Dec 20, 2016
|
Tests fail |
MorrisJobke
added
2. developing
Local shares should only be scanned when doing it for the owner to avoid repeatedly rescanning the same shared storage over and over again for every recipient.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From owncloud/core#26590