hide personal circle from the sharedWithMe #27633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
blizzz
reviewed
Jun 23, 2021
| undefined, | ||
| { escape: false } | ||
| ) | ||
| if (share.shareWithDisplayName === ' ') { |
There was a problem hiding this comment.
yup, as said if I return an empty string, the ID of the Circle/Share will be used as displayName. single whitespace is a quick workaround
|
What is missing here? |
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Personal Circle are hidden to its own members (but the owner of the Circle).
Because shareWithDisplayName cannot be empty, or it will be replaced by the Id of the share, the work around is that the Circles App will returns a name with a space char.
The idea is that when sharing a file to a personal Circle, the recipient of the share is not aware of the fact that he is in a personal Circle.