Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "First attempt to check against core routes before loading all app routes" #27715

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

PVince81
Copy link
Member

Reverts #24295

Fixes nextcloud/guests#654

Unless there's a better reliable short term solution, see #24295 (comment)

@PVince81 PVince81 added this to the Nextcloud 23 milestone Jun 29, 2021
@PVince81 PVince81 self-assigned this Jun 29, 2021
@PVince81
Copy link
Member Author

/backport to stable22

… app routes"

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the revert-24295-perf/noid/router branch from c018896 to 8535340 Compare June 29, 2021 15:55
@PVince81
Copy link
Member Author

amended the commit message to make DCO bot happy

@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 29, 2021
@PVince81
Copy link
Member Author

test failure probably unrelated:

SettingsContext::iSeeThatTheDropdownForTagsInTheSettingsEventuallyContainsTheTag()
      Select2 dropdown mask in Settings could not be found (NoSuchElementException)

it didn't fail in the previous run before I amended the commit text: https://drone.nextcloud.com/nextcloud/server/6729/57/4

please force-merge, then...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guest users must not be able to search for other users
4 participants