Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing files for Composer v2 #28420

Merged
merged 1 commit into from
Aug 15, 2021
Merged

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Aug 13, 2021

As of Composer v2 there is a generated file that holds infos about the installed packages of a composer project. That file is linked to from the autoloader map:

'Composer\\InstalledVersions' => __DIR__ . '/..' . '/composer/InstalledVersions.php',
. That's a problem because there are packages that try to load that class if it exists.

This issues was discovered in ChristophWurst/nextcloud_sentry#331 and has caused some additional load on our company instance.

I will backport this change manually to all major versions that use composer v2.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added bug 3. to review Waiting for reviews labels Aug 13, 2021
@ChristophWurst ChristophWurst added this to the Nextcloud 23 milestone Aug 13, 2021
@ChristophWurst ChristophWurst self-assigned this Aug 13, 2021
@ChristophWurst ChristophWurst added this to TO REVIEW (max 4 PRs) in Christoph's Tasks via automation Aug 13, 2021
@@ -25,7 +25,8 @@ for app in ${REPODIR}/apps/*; do
if [[ -d $app ]]; then
if [[ -e ${app}/composer/composer.json ]]; then
echo
echo "Regenerating autoloader for ${app}"
echo "Regenerating composer files for ${app}"
$COMPOSER_COMMAND i --no-dev -d ${app}/composer
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you find my two lines of change. the rest was generated by composer 😉

Christoph's Tasks automation moved this from TO REVIEW (max 4 PRs) to TO INTEGRATE Aug 13, 2021
@skjnldsv skjnldsv merged commit d24929b into master Aug 15, 2021
@skjnldsv skjnldsv deleted the fix/composer-2-missing-files branch August 15, 2021 08:25
Christoph's Tasks automation moved this from TO INTEGRATE to DONE Aug 15, 2021
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants