dav: fix birthday calendar event generation for leap days #29010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattian
force-pushed
the
fix/19218/birthday-leap-day
branch
from
08a27cf
to
605e430
Compare
mattian
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
|
Please rebase |
mattian
force-pushed
the
fix/19218/birthday-leap-day
branch
from
605e430
to
ac0627b
Compare
Merged
ChristophWurst
approved these changes
Oct 17, 2022
mattian
force-pushed
the
fix/19218/birthday-leap-day
branch
from
ac0627b
to
583b6c3
Compare
|
Drone failing with: unrelated. Performance testing is only checking for origin remote. |
ChristophWurst
added
4. to release
Merged
Fix generation of birthday calendar events for the 29th of February. A recurring event for the 29th of February in the (default) Gregorian calendar system would only generate instances in leap years. Fix this behaviour by generating recurring events for the last day of February, the 29th on leap years and the 28th otherwise. Signed-off-by: Mattia Narducci <mattianarducci1@gmail.com>
mattian
force-pushed
the
fix/19218/birthday-leap-day
branch
from
583b6c3
to
b55c62c
Compare
|
@blizzz drone failure unrelated, force merge would be apprechiated. |
|
thanks @mattian 😄 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19218.
Fix generation of birthday calendar events for the 29th of February.