Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change output format of Psalm to Github #29044

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Conversation

MorrisJobke
Copy link
Member

This automatically inlines the errors into the diff view on Github. 馃槈

This automatically inlines the errors into the diff view.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憢

@MichaIng
Copy link
Member

MichaIng commented Oct 3, 2021

/backport to stable22

@MichaIng
Copy link
Member

MichaIng commented Oct 3, 2021

Does this work with the (older) Psalm versions on NC21 and NC20?

@MorrisJobke
Copy link
Member Author

I guess that it should work there 馃憤

@MichaIng
Copy link
Member

MichaIng commented Oct 3, 2021

/backport to stable21

@MichaIng
Copy link
Member

MichaIng commented Oct 3, 2021

Let's simply try it out. For NC20 the backport needs to be done manually as it doesn't contain the static-code-analysis-ocp job yet.

@kesselb kesselb merged commit fa01cac into master Oct 3, 2021
@kesselb kesselb deleted the ci/noid/psalm-inline-gitub branch October 3, 2021 17:37
@backportbot-nextcloud
Copy link

The backport to stable21 failed. Please do this backport manually.

MichaIng added a commit that referenced this pull request Oct 3, 2021
Manual backport of #29044

Signed-off-by: MichaIng <micha@dietpi.com>
MichaIng added a commit that referenced this pull request Oct 3, 2021
Manual backport of #29044

Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng
Copy link
Member

MichaIng commented Oct 3, 2021

@MichaIng MichaIng added this to the Nextcloud 23 milestone Oct 3, 2021
@kesselb
Copy link
Contributor

kesselb commented Oct 3, 2021

Hello @MorrisJobke 馃憢

Don't forget to signup for hacktoberfest 馃槑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants