Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if user's groups can see tag #29277

Closed

Conversation

rickyelopez
Copy link

Addresses at least one of the concerns in #4699, though not fully since there isn't a way to add a group to a tag from the frontend.

@rickyelopez
Copy link
Author

Hi @skjnldsv, I see you're active in this project. Can you take a look at this? Do I need to create an issue to potentially merge this down the line, or is this PR sufficient?

Signed-off-by: Ricky Lopez <rickyerlopez@gmail.com>
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not understand this change, if you look at the beginning of canUserSeeTag, there is a check for isUserVisible already.

So here you are making tags visible which were not supposed to be?

In canUserAssignTag which you copied code from, the groups are only checked for user visible tags.

@rickyelopez
Copy link
Author

I thought I had deleted this, I gave up on tags a long time ago. All yours if you want it, @AndyScherzinger.

@skjnldsv skjnldsv closed this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants