[sub-PR] Move common logic to share manager #29561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
feat/28139/move-logic-to-share-manager
branch
from
eaf8af6
to
f8d9c12
Compare
Pytal
reviewed
Nov 5, 2021
| @@ -447,6 +448,16 @@ public function limitEnumerationToPhone(): bool; | |||
| */ | |||
| public function allowEnumerationFullMatch(): bool; | |||
|
|
|||
| /** | |||
| * Check if a user A can enumerate another user B | |||
There was a problem hiding this comment.
Should reflect function parameter names :)
Pytal
force-pushed
the
feat/28139/profile-respect-user-enumeration
branch
from
e8b47b9
to
f4307ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #29559 (comment)