Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/webpack vendors bundles #30020

Merged
merged 28 commits into from
Jan 10, 2022
Merged

Feat/webpack vendors bundles #30020

merged 28 commits into from
Jan 10, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Dec 1, 2021 •
edited

  • Reduce compile time by a power of 4
  • Move all bundles into /dist
  • Easier to cleanup
  • Easier to target old legacy js files
  • No more vue- or js/dist hacks
  • Bundle all shared modules into one big cached file

@artonge artonge force-pushed the feat/webpack-vendors-bundles branch from c4251a2 to e9039ed Compare December 1, 2021 21:34
@skjnldsv skjnldsv force-pushed the feat/webpack-vendors-bundles branch 2 times, most recently from 80c15ed to 5adab26 Compare December 2, 2021 18:14
@skjnldsv skjnldsv marked this pull request as ready for review December 2, 2021 18:14
@skjnldsv skjnldsv requested review from a team, PVince81, Pytal, szaimen, nickvergessen and artonge and removed request for a team December 2, 2021 18:15
@skjnldsv skjnldsv self-assigned this Dec 2, 2021
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Dec 2, 2021
artonge
artonge reviewed Dec 2, 2021
View reviewed changes
core/src/OCP/collaboration.js Show resolved Hide resolved
lib/private/legacy/OC_Template.php Outdated Show resolved Hide resolved
webpack.common.js Outdated Show resolved Hide resolved
Pytal
Pytal reviewed Dec 2, 2021
View reviewed changes
.eslintrc.js Show resolved Hide resolved
@skjnldsv skjnldsv force-pushed the feat/webpack-vendors-bundles branch 4 times, most recently from f5c36fe to 6eb2287 Compare December 2, 2021 21:41
@Pytal Pytal mentioned this pull request Dec 3, 2021
Merged
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Dec 3, 2021
@artonge artonge force-pushed the feat/webpack-vendors-bundles branch from 525c4ff to 60dc882 Compare December 3, 2021 13:04
@skjnldsv

This comment has been minimized.

Sign in to view
@artonge @skjnldsv
Compile bundle
a6874aa 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Fix webpack version
cd53bc8 
Reason: webpack/webpack#14628
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Don't import $ in every file that needs it
19ed04d 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Fix undescore version
9ee339d 
Reason: #27279
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Restore line in autotest-js
db752fb 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Revert build/package-lock.json change
8a56713 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Detect app's script higher up as some scripts were shadowed
6f62c17 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Reset $scriptDeps in tests
447cd55 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Deprecate script function
d3661c7 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge @skjnldsv
Bump p-queue
9ed12e8 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 8, 2022

Rebased

@skjnldsv skjnldsv force-pushed the feat/webpack-vendors-bundles branch from 1c37a42 to 9ed12e8 Compare January 8, 2022 09:16
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 8, 2022 •
edited 

Scenario: delete a user                                                      # /drone/src/tests/acceptance/features/users.feature:25
130 | Given I act as Jane                                                        # ActorContext::iActAs()
131 | And I am logged in as the admin                                            # LoginPageContext::iAmLoggedInAsTheAdmin()
132 | And I open the User settings                                               # SettingsMenuContext::iOpenTheUserSettings()
133 | And I see that the list of users contains the user user0                   # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
134 | And I open the actions menu for the user user0                             # UsersSettingsContext::iOpenTheActionsMenuOf()
135 | And I see that the "Delete user" action in the user0 actions menu is shown # UsersSettingsContext::iSeeTheAction()
136 | Failed asserting that false is true.
137 | When I click the "Delete user" action in the user0 actions menu            # UsersSettingsContext::iClickTheAction()
138 | And I click the "Delete user0's account" button of the confirmation dialog # DialogContext::iClickTheDialogButton()
139 | Then I see that the list of users does not contains the user user0         # UsersSettingsContext::iSeeThatTheListOfUsersDoesNotContainsTheUser()
140

Is valid, the menu does not open anymore.

EDIT: fixed and pushed 🚀

@skjnldsv

This comment has been minimized.

Sign in to view
@skjnldsv @nextcloud-command
Use sync modifier with openMenu
79f14e8 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
skjnldsv
skjnldsv commented Jan 8, 2022
View reviewed changes
lib/private/legacy/template/functions.php Outdated
* @param string $app the appname
* @param string|string[] $file the filename,
* if an array is given it will add all scripts
* @deprecated 23.1.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 23.1.0 ?
Should be 24 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, my bad

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix on followup so we don't yet rebase this monstrous PR 🙈

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please add a pointer to its replacement.

skjnldsv
skjnldsv commented Jan 8, 2022
View reviewed changes
lib/public/Util.php Outdated Show resolved Hide resolved
@CarlSchwan CarlSchwan merged commit 91c7efa into master Jan 10, 2022
@CarlSchwan CarlSchwan deleted the feat/webpack-vendors-bundles branch January 10, 2022 08:41
@artonge artonge mentioned this pull request Jan 27, 2022
Merged
This was referenced Feb 11, 2022
Merged
Closed
Merged
@artonge artonge mentioned this pull request Feb 18, 2022
Merged
@juliushaertl juliushaertl mentioned this pull request Mar 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz left review comments

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@szaimen szaimen Awaiting requested review from szaimen

@nickvergessen nickvergessen Awaiting requested review from nickvergessen nickvergessen is a code owner

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@Pytal Pytal Awaiting requested review from Pytal

@mejo- mejo- Awaiting requested review from mejo-

@MichaIng MichaIng Awaiting requested review from MichaIng

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement technical debt
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@skjnldsv @artonge @mejo- @blizzz @CarlSchwan @Pytal @MichaIng