Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAV SEARCH: Expose upload_time and creation_time #30366

Closed
wants to merge 2 commits into from

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Dec 21, 2021

fixes #21385

This would be very useful for nextcloud/photos#87

@marcelklehr
Copy link
Member Author

php-cs linter fails due to unrelated file lib/private/Files/ObjectStore/S3ConnectionTrait.php

@marcelklehr
Copy link
Member Author

@icewind1991 Does Node#getFileInfo()->getCreationTime() return the file system creation time, or some value maintained in nextcloud? In my tests with this PR it always returns 0.

@szaimen
Copy link
Contributor

szaimen commented Dec 28, 2021

/rebase

@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
@blizzz blizzz mentioned this pull request Mar 31, 2022
This was referenced Apr 7, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
@szaimen szaimen requested a review from CarlSchwan April 27, 2022 17:33
@CarlSchwan
Copy link
Member

Does Node#getFileInfo()->getCreationTime() return the file system creation time, or some value maintained in nextcloud? In my tests with this PR it always returns 0.

From that I understand the creation_time is set here:

if (isset($this->request->server['HTTP_X_OC_CTIME'])) {

So a client needs to send the time explicitly when uploading a file. Reading the desktop client source code, I can't find where this is set :(

@PVince81
Copy link
Member

maybe @mgallien for where the creation time is sent ?

@mgallien
Copy link
Contributor

maybe @mgallien for where the creation time is sent ?

my understanding is that desktop client only sets X-OC-Mtime and never any X-OC-Ctime

I confirm what @CarlSchwan said

@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@ChristophWurst ChristophWurst removed their request for review October 17, 2022 09:44
@szaimen
Copy link
Contributor

szaimen commented Jan 11, 2023

Hi everyone, what is needed to get this done? :)

@marcelklehr
Copy link
Member Author

This was based on wrong assumptions

@ChristophWurst ChristophWurst deleted the feat/dav/creation-date branch January 11, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload time and Creation time in searchrequest
7 participants