-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accessing undefined offsets #30795
Conversation
Move this to inside the else clause of the count($matches) Signed-off-by: Carl Schwan <carl@carlschwan.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈
/backport to stable23 |
/backport to stable22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 as discussed
samba test failed without results since this PR is connected, I've restarted the build just in case, hoping for the best... |
It indeed looks connected but at the same time it's also broken on master. 😱 Maybe the tests broke with the PR that added this feature? |
Let's focus on fixing the tests on #30796 |
not connected, this was here after the SMB bump of yesterday, Robin have been notified :) |
@skjnldsv my suggestion was discarded :) |
@acsfer what do you mean? |
@skjnldsv see
;; on master and backports...)
|
It works never the less? |
yeah, it will work. The additional semicolon is just an empty statement, I will submit Monday a PR to fix it in master but there is no need to backport this. |
Sure, but merge a PR with this "typo" after it was pointed-out it's a bit, let's say, strange... :) |
I'm not sure where this was pointed out. Did you maybe forgot to submit the comment? I only see your message about your suggestions being discarded but this one after merging this PR. |
Move this to inside the else clause of the count($matches)
Signed-off-by: Carl Schwan carl@carlschwan.eu