Fix Calendar sends duplicate notifications if there is an additional attendee (#21370) #30980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kominoshja
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
miaulalala
approved these changes
Mar 14, 2022
miaulalala
requested review from
a team,
nickvergessen,
icewind1991 and
come-nc
and removed request for
a team
| @@ -68,7 +68,8 @@ public function getRemindersToProcess():array { | |||
| ->from('calendar_reminders', 'cr') | |||
| ->where($query->expr()->lte('cr.notification_date', $query->createNamedParameter($this->timeFactory->getTime()))) | |||
| ->join('cr', 'calendarobjects', 'co', $query->expr()->eq('cr.object_id', 'co.id')) | |||
| ->join('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id')); | |||
| ->join('cr', 'calendars', 'c', $query->expr()->eq('cr.calendar_id', 'c.id')) | |||
| ->groupBy(['cr.event_hash','cr.type','cr.uid']); | |||
There was a problem hiding this comment.
This fails on some DB configurations:
https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_only_full_group_by
There was a problem hiding this comment.
good to know. I guess I have to do the grouping in memory.
There was a problem hiding this comment.
Select those columns on L67 as well, then you can still run this on the DB
There was a problem hiding this comment.
Select those columns on L67 as well
That's not right it. It's the other way around: All items that are selected need to be aggregated.
But I agree, if we previously did not group on db level, just group manually in php.
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
|
This problem persists on NC25. Any plans to merge this patch? Thank you! |
tcitworld
added
2. developing
Merged
|
Fixed already by #34909 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug disclosed on #21370 still occurs on Nextcloud 23. The patch provided by @EhiOnime fixes this issue, but they never made a PR, so it continued to happen.