New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert the 'broken' public page changes #31077
Conversation
/backport to stable22 |
/backport to stable23 |
Thanks Carl but maybe we should also think about reverting the hidden space change because it might introduce this? |
Related to #31040? |
@CarlSchwan I've also reverted "Add non-breaking space in the file size" because of #31017. I hope thats fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and works 👍
(it fixes all mentioned issues)
This should be pushed to the Hotfix to come as a regression IMO. |
cc @PVince81 on that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the text app cypress tests for sharing against this branch of the server and they pass.
They caught the initial regression but were also fixed by the workaround commit in the meantime. So this test run only means this branch did not introduce another regression for sharing in text.
I did not look at the code as i assume it just reverts the commits and i did not check the error reports and check if they are fixed by this as it sounds like @szaimen already did so.
fd0b33d
to
f042437
Compare
Samba failure unrekated |
The backport to stable22 failed. Please do this backport manually. |
/backport to stable23 |
@CarlSchwan seems one of the PRs made it to stable22: #30697 but not the other one. |
Stable22 was already reverted |
/backport f042437 to stable22 |
Reverts #30655 and #30719
Fix #31076
Fix #31040
Fix #31017
Let's revert it for now and see if we can later rework that in a better way.
This keeps the change about the fileSize variable containing a nonbreaking space but reverts all the CSS changesThis reverts all changes.