Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the 'broken' public page changes #31077

Merged
merged 3 commits into from Feb 10, 2022
Merged

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Feb 8, 2022

Reverts #30655 and #30719
Fix #31076
Fix #31040
Fix #31017

Let's revert it for now and see if we can later rework that in a better way. This keeps the change about the fileSize variable containing a nonbreaking space but reverts all the CSS changes This reverts all changes.

@CarlSchwan
Copy link
Member Author

/backport to stable22

@CarlSchwan
Copy link
Member Author

/backport to stable23

@szaimen
Copy link
Contributor

szaimen commented Feb 8, 2022

Thanks Carl but maybe we should also think about reverting the hidden space change because it might introduce this?
#31017

@solracsf
Copy link
Member

solracsf commented Feb 8, 2022

Related to #31040?

@szaimen
Copy link
Contributor

szaimen commented Feb 9, 2022

@CarlSchwan I've also reverted "Add non-breaking space in the file size" because of #31017. I hope thats fine!

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍
(it fixes all mentioned issues)

@solracsf
Copy link
Member

solracsf commented Feb 9, 2022

This should be pushed to the Hotfix to come as a regression IMO.

@szaimen
Copy link
Contributor

szaimen commented Feb 9, 2022

This should be pushed to the Hotfix to come as a regression IMO.

cc @PVince81 on that

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the text app cypress tests for sharing against this branch of the server and they pass.
They caught the initial regression but were also fixed by the workaround commit in the meantime. So this test run only means this branch did not introduce another regression for sharing in text.
I did not look at the code as i assume it just reverts the commits and i did not check the error reports and check if they are fixed by this as it sounds like @szaimen already did so.

CarlSchwan and others added 3 commits February 10, 2022 10:35
This reverts commit d3d117c.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
This reverts commit 2e55ce0.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 10, 2022
@szaimen
Copy link
Contributor

szaimen commented Feb 10, 2022

Samba failure unrekated

@szaimen szaimen merged commit b881940 into master Feb 10, 2022
@szaimen szaimen deleted the revert/public-page-changes branch February 10, 2022 16:37
@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@CarlSchwan
Copy link
Member Author

/backport to stable23

@PVince81
Copy link
Member

@CarlSchwan seems one of the PRs made it to stable22: #30697 but not the other one.
Can you do a manual backport if applicable ?

@CarlSchwan
Copy link
Member Author

Stable22 was already reverted

@szaimen
Copy link
Contributor

szaimen commented Feb 10, 2022

/backport f042437 to stable22

@szaimen
Copy link
Contributor

szaimen commented Feb 10, 2022

@PVince81 f042437 was missing from the backport to stable22 (I had a look at the backport)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
6 participants