Add menuitem to popover menu #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
3. to review
skjnldsv
requested review from
rullzer,
MorrisJobke,
jancborchardt and
ChristophWurst
So is this actually useful now? How can we test this? |
|
Well in the popover menus, we aim for 'a' or 'button' only children, but since the upload popovers (gallery and files) are using a label to link it to the input file I thought we should add it for compatibility with old apps and for occasional uses like these. :) you can test it by clicking the add file button on files or gallery (which require some more fixes too) |
What happened there? 😁 We definitely have to fix that |
ChristophWurst
approved these changes
Jan 17, 2017
Incoming. |
|
definitely a improvement, compared with master 👍 |
schiessle
approved these changes
Jan 17, 2017
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be useful for occasional popover sub-items (like the upload file menu for example)