Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "goto" links for files in non-default file lists #312

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

icewind1991
Copy link
Member

Clicking on the "goto" link navigates you to the folder containing the file and highlights it.

goto link

This makes it easy to find a favorite/shared/tagged file in the context of it's folder, allowing things like moving them or finding other files in the folder.

todo:

  • better icon

cc @nextcloud/designers

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 5, 2016
@icewind1991 icewind1991 added this to the Nextcloud Next milestone Jul 5, 2016
@jancborchardt
Copy link
Member

This should definitely be in the 3-dot actions menu, not just put directly in the list. :) Especially because I guess every file/folder would have this, even those in root.

In general again, similar to the »Recent files« thing: I'd much rather have it that we integrate Favorites better in the All files view by sorting the Favorites up top in each view – instead of adding more stuff to other views. Ref owncloud/core#23920

@williambargent
Copy link
Member

I agree, great featured but I don't think its important/used enough to value having its own icon on the file ribbon.

@jancborchardt
Copy link
Member

jancborchardt commented Jul 5, 2016

Ok cool, so we talked about this and moving to the 3-dot dropdown is good. The icon is fitting and we should call it maybe »View in folder«.

This action is also useful for the search view, and the other file list filters like Shared, etc

@icewind1991
Copy link
Member Author

Switched it to the dropdown

@williambargent
Copy link
Member

👍

@icewind1991
Copy link
Member Author

Made scrutinizer happy and squashed everything

@MorrisJobke
Copy link
Member

Tested and works 👍

The icon could be changed afterwards anyways

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants