Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix developer link #31355

Merged
merged 1 commit into from Mar 1, 2022
Merged

fix developer link #31355

merged 1 commit into from Mar 1, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 25, 2022 •
edited

Fix #23441

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=fix/23441/fix-developer-link \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 24 milestone Feb 25, 2022
@szaimen szaimen force-pushed the fix/23441/fix-developer-link branch 2 times, most recently from e0b5368 to 5c0ab4d Compare February 28, 2022 13:06
@szaimen
Copy link
Contributor Author

szaimen commented Feb 28, 2022

/compile amend /

@szaimen @skjnldsv
try to fix developer link
ec2462d 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv force-pushed the fix/23441/fix-developer-link branch from 2d95711 to ec2462d Compare March 1, 2022 08:04
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 1, 2022
@skjnldsv skjnldsv requested review from a team, PVince81, artonge and vanpertsch and removed request for a team March 1, 2022 08:04
@skjnldsv skjnldsv marked this pull request as ready for review March 1, 2022 08:04
@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

/backport to stable22

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 1, 2022
@szaimen szaimen merged commit 774fac1 into master Mar 1, 2022
@szaimen szaimen deleted the fix/23441/fix-developer-link branch March 1, 2022 09:42
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

/backport to stable22

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 1, 2022

Seems like it really needs to be done manuall

@szaimen szaimen restored the fix/23441/fix-developer-link branch March 3, 2022 12:16
@szaimen szaimen mentioned this pull request Mar 3, 2022
Merged
@szaimen szaimen deleted the fix/23441/fix-developer-link branch March 3, 2022 12:22
@szaimen szaimen changed the title try to fix developer link fix developer link Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: apps management
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Link to 'Developer documentation' doesn't work on Apps page
3 participants
@szaimen @artonge @skjnldsv