Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return type of avatar file #31417

Merged
merged 1 commit into from Mar 3, 2022
Merged

Fix return type of avatar file #31417

merged 1 commit into from Mar 3, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 3, 2022

The implementations return either ISimpleFile or InMemoryFile

  • /**
    * Returns the avatar for an user.
    *
    * If there is no avatar file yet, one is generated.
    *
    * @param int $size
    * @return ISimpleFile
    * @throws NotFoundException
    * @throws \OCP\Files\NotPermittedException
    * @throws \OCP\PreConditionNotMetException
    */
    public function getFile($size) {
  • /**
    * Returns the avatar for an user.
    *
    * If there is no avatar file yet, one is generated.
    *
    * @param int $size
    * @return ISimpleFile
    * @throws NotFoundException
    * @throws \OCP\Files\NotPermittedException
    * @throws \OCP\PreConditionNotMetException
    */
    public function getFile($size) {
  • /**
    * Generates an avatar for the guest.
    *
    * @param int $size The desired image size.
    * @return InMemoryFile
    */

@Pytal Pytal added bug 3. to review Waiting for reviews labels Mar 3, 2022
@Pytal Pytal added this to the Nextcloud 24 milestone Mar 3, 2022
@Pytal Pytal requested review from come-nc and a team March 3, 2022 04:47
@Pytal Pytal self-assigned this Mar 3, 2022
@Pytal Pytal requested review from PVince81 and ArtificialOwl and removed request for a team March 3, 2022 04:47
@Pytal Pytal mentioned this pull request Mar 3, 2022
5 tasks
lib/public/IAvatar.php Outdated Show resolved Hide resolved
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the change already mentioned by @come-nc

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal requested a review from come-nc March 3, 2022 16:07
@Pytal
Copy link
Member Author

Pytal commented Mar 3, 2022

/backport to stable23

@Pytal
Copy link
Member Author

Pytal commented Mar 3, 2022

/backport to stable22

@Pytal
Copy link
Member Author

Pytal commented Mar 3, 2022

/backport to stable21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants