Part 1 of LDAP Backend OCS Api #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
66 tasks
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
|
Hm, actually, unlike the CLI thing, we could set not only one but all any config keys with one request. Will improve this tomorrow. |
Current coverage is 53.76% (diff: 2.67%)@@ master #3162 diff @@
==========================================
Files 1299 1303 +4
Lines 80135 81003 +868
Methods 7909 7974 +65
Messages 0 0
Branches 1248 1303 +55
==========================================
+ Hits 43227 43555 +328
- Misses 36908 37447 +539
- Partials 0 1 +1
|
|
MorrisJobke
reviewed
Jan 19, 2017
| @@ -413,6 +413,15 @@ pipeline: | |||
| when: | |||
| matrix: | |||
| TESTS: integration-transfer-ownership-features | |||
| integration-ldap-features: | |||
There was a problem hiding this comment.
indentation is wrong. Let me fix that 😉
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Should be fixed now 😃 |
| Then the OCS status code should be "400" | ||
| And the HTTP status code should be "400" | ||
|
|
||
| Scenario: Modiying a non-existing configuration |
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
3. to review
Also move ensureConfigIDExists checks into try, it might throw DB related exceptions Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
covered by "Delete a non-existing configuration" Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
And done! 😹 Deleted my config and restored it using the API 🚀 🎸 |
|
Final reviews? 😸 |
schiessle
approved these changes
Jan 23, 2017
This was referenced Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2694
It brings OCS Api methods for creating, reading, modifying and deleting an LDAP configuration. Including integration tests (Configuration manipulation is against DB only, no LDAP server interaction).
General appconfig does not suffice here, because some values are not written to the DB as is, but need to be transformed first (i.e. multiline values, password). Also some sanity-checking is happening.
Please review @nextcloud/ldap