Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Toggle profile globally #31624

Merged
merged 2 commits into from Mar 25, 2022
Merged

[stable23] Toggle profile globally #31624

merged 2 commits into from Mar 25, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 19, 2022

Backport of #29372

@Pytal Pytal added enhancement 3. to review Waiting for reviews feature: settings feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Mar 19, 2022
@Pytal Pytal added this to the Nextcloud 23.0.4 milestone Mar 19, 2022
@Pytal Pytal requested review from artonge, szaimen and a team March 19, 2022 00:47
@Pytal Pytal self-assigned this Mar 19, 2022
@Pytal Pytal requested review from skjnldsv, PVince81 and CarlSchwan and removed request for a team March 19, 2022 00:47
@Pytal Pytal mentioned this pull request Mar 19, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Mar 19, 2022

Is it expected that this changes much less files and code than in NC24? I didn't try it out but could do so...

@artonge
Copy link
Contributor

artonge commented Mar 21, 2022

Is it expected that this changes much less files and code than in NC24? I didn't try it out but could do so...

It's due to the changes we did on the frontend files bundling. The 24 PR changes all the output files, and this PR only changes the settings output files. So way less files.

It should be good :)

@szaimen
Copy link
Contributor

szaimen commented Mar 21, 2022

/rebase

@Pytal Pytal requested a review from a team March 21, 2022 19:41
@Pytal Pytal mentioned this pull request Mar 22, 2022
Merged
@szaimen szaimen mentioned this pull request Mar 24, 2022
Merged
PVince81
PVince81 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Pytal
Copy link
Member Author

Pytal commented Mar 24, 2022

Triggered CI rerun

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 24, 2022
@Pytal
Add global profile toggle config
8bef2ec 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 1fc0b43)
@Pytal
Add profile default setting for admin
d8c0446 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 108abd7)
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Mar 25, 2022

CI failure unrelated

@Pytal Pytal merged commit fea072c into stable23 Mar 25, 2022
@Pytal Pytal deleted the backport/29372/stable23 branch March 25, 2022 05:26
@szaimen szaimen mentioned this pull request Mar 28, 2022
Closed
@blizzz blizzz mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) feature: settings
Projects
None yet
Milestone
Nextcloud 23.0.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Pytal @szaimen @artonge @PVince81