Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error: Undefined index: redirect_url #31947

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix Error: Undefined index: redirect_url #31947

merged 1 commit into from
Oct 6, 2022

Conversation

AndyXheli
Copy link
Contributor

@AndyXheli AndyXheli commented Apr 12, 2022

Signed-off-by: Andy Xheli axheli@axtsolutions.com

Should fix Undefined index: redirect_url at core/templates/twofactorsetupselection.php #21968

#21968 (comment)

Signed-off-by: Andy Xheli <axheli@axtsolutions.com>

Should fix Undefined index: redirect_url at core/templates/twofactorsetupselection.php #21968
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looking at core/Controller/TwoFactorChallengeController.php::setupProviders, we indeed don't provide this variable

@szaimen szaimen added bug 3. to review Waiting for reviews labels Apr 12, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Apr 12, 2022
@AndyXheli
Copy link
Contributor Author

@szaimen Can we also backport once approved to NC 23 ?

@nickvergessen
Copy link
Member

Would be better to restore the value so when you clicked on a link and need to authenticate, you do end up at the first link again?

@blizzz blizzz mentioned this pull request Apr 13, 2022
@blizzz blizzz modified the milestones: Nextcloud 24, Nextcloud 25 Apr 21, 2022
This was referenced Aug 12, 2022
This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@AndyXheli
Copy link
Contributor Author

@blizzz any way we can get this in NC 25 and backport this to NC 24 please ?

Still getting this message anytime a user setups 2fa for the first time

image

@blizzz blizzz merged commit 1bf7dba into nextcloud:master Oct 6, 2022
@blizzz
Copy link
Member

blizzz commented Oct 6, 2022

/backport to stable25

@blizzz
Copy link
Member

blizzz commented Oct 6, 2022

/backport to stable24

@mickenordin
Copy link
Contributor

Would be nice to have this in version 23 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined index: redirect_url at core/templates/twofactorsetupselection.php
8 participants