Check maintenance window time when using WebCron #32107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch moves maintenance window check earlier so that maintenance window was respected when using both system cron and WebCron. Before the change webcron used to select **only** time-sensitive tasks. Signed-off-by: Kirill Popov <kirill.s.popov@gmail.com>
szaimen
requested review from
nickvergessen,
a team,
icewind1991,
blizzz and
juliushaertl
and removed request for
a team
nickvergessen
requested changes
Apr 23, 2022
| @@ -167,8 +168,9 @@ | |||
| } else { | |||
| // Work and success :-) | |||
| $jobList = \OC::$server->getJobList(); | |||
| $job = $jobList->getNext(); | |||
| $job = $jobList->getNext($onlyTimeSensitive); | |||
There was a problem hiding this comment.
The actual fix would be to just inject false here or change the default of the method
There was a problem hiding this comment.
Could you please comment why?
I'm running NextCloud in Kubernetes and thus I can't use system cron daemon. Having Kubernetes' CronJob is a solution - it runs periodically and "curl's" cron.php. In this setup I still have short background jobs and time-sensitive ones which I want to run during maintenance hours.
There was a problem hiding this comment.
Explanation in #30899 (comment)
8 tasks
|
I've opened #32109 with argument default change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch moves maintenance window check earlier so that
maintenance window was respected when using both system cron
and WebCron. Before the change webcron used to select
only time-sensitive tasks.
Signed-off-by: Kirill Popov kirill.s.popov@gmail.com