[stable24] only need to setup root for groupfolders #32141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
Signed-off-by: Robin Appelman <robin@icewind.nl>
backportbot-nextcloud
bot
requested review from
ArtificialOwl,
CarlSchwan,
icewind1991,
PVince81 and
vanpertsch
PVince81
reviewed
Apr 25, 2022
| @@ -344,7 +344,9 @@ public function setupRoot(): void { | |||
| * @return IUser|null | |||
| */ | |||
| private function getUserForPath(string $path) { | |||
| if (substr_count($path, '/') < 2) { | |||
| if (strpos($path, '/__groupfolders') === 0) { | |||
There was a problem hiding this comment.
now thinking, we do have https://www.php.net/manual/en/function.str-starts-with.php and a polyfill now, should we start using it ? I guess it might be more performant than doing strpos as it doesn't need to search the whole string
something for later @icewind1991 @CarlSchwan
come-nc
approved these changes
Apr 26, 2022
blizzz
added
the
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32084