Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include more emoji chars to test and fixes after include it #32220

Merged
merged 1 commit into from May 3, 2022
Merged

Include more emoji chars to test and fixes after include it #32220

merged 1 commit into from May 3, 2022

Conversation

vitormattos
Copy link
Contributor

@vitormattos vitormattos commented Apr 29, 2022 •
edited

Scenario before:
tests breaking with specific emojis

Scenario after:
All emoji used in emoji picker working fine.

@vitormattos
Include more emoji chars to test and fixes after include it
cefcd55 
Signed-off-by: Vitor Mattos <vitor@php.rio>
@vitormattos vitormattos added the 3. to review Waiting for reviews label Apr 29, 2022
@vitormattos vitormattos added this to the Nextcloud 25 milestone Apr 29, 2022
@vitormattos vitormattos self-assigned this Apr 29, 2022
@vitormattos vitormattos mentioned this pull request May 2, 2022
Closed
@vitormattos
Copy link
Contributor Author

The broken scenarios don't have relation with this PR:

src/tests/acceptance/features/app-files-sharing.feature:23
src/tests/acceptance/features/app-files-sharing.feature:266
src/tests/acceptance/features/app-files-sharing.feature:291

@nickvergessen nickvergessen merged commit 290697b into master May 3, 2022
@nickvergessen nickvergessen deleted the feature/add-tests-to-validate-emojis branch May 3, 2022 14:08
@vitormattos vitormattos mentioned this pull request May 3, 2022
Merged
@vitormattos vitormattos mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees

@vitormattos vitormattos

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitormattos @nickvergessen @CarlSchwan