Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put calendar invites into the user's first available calendar #32361

Merged
merged 2 commits into from Jun 10, 2022

Conversation

tcitworld
Copy link
Member

If there's no default calendar and we can't find anything with URI 'personal', instead of creating a new one, start by using the first "real personal calendar" available.

If not, then we create the default one.

@tcitworld tcitworld added 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels May 12, 2022
@tcitworld tcitworld added this to the Nextcloud 25 milestone May 12, 2022
@tcitworld tcitworld requested a review from a team May 12, 2022 13:15
@tcitworld tcitworld added this to In progress in Thomas things to do via automation May 12, 2022
@ChristophWurst
Copy link
Member

ChristophWurst commented May 12, 2022

A related problem occurs when you do the following

  • Open the Calendar app for the first time -> it creates a personal calendar for you
  • Delete that calendar
  • Reload the page -> it creates a personal-1 calendar for you
  • Have someone invite you to an event

-> The event isn't shown because it's put into the deleted calendar.

In other words, maybe we should find the first own, read-write and non-deleted calendar :)

If there's no default calendar and we can't find anything with URI
'personal', instead of creating a new one, start by using the first
"real personal calendar" available.

If not, then we create the default one.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the dav-scheduling-default-calendar branch from 57875de to a7b2e8a Compare May 12, 2022 13:28
@tcitworld
Copy link
Member Author

tcitworld commented May 12, 2022

In other words, maybe we should find the first own, read-write and non-deleted calendar :)

That's what this PR does now, I had just forgot to check for the deleted state of the calendar.

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thomas things to do automation moved this from In progress to Reviewer approved Jun 10, 2022
@PVince81 PVince81 merged commit dcfdcf9 into master Jun 10, 2022
Thomas things to do automation moved this from Reviewer approved to Done Jun 10, 2022
@PVince81 PVince81 deleted the dav-scheduling-default-calendar branch June 10, 2022 14:03
tcitworld added a commit that referenced this pull request Feb 7, 2023
…n the current calendar is in the trashbin

Follow-up to #32361, see nextcloud/calendar#4098 for details

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Feb 9, 2023
…n the current calendar is in the trashbin

Follow-up to #32361, see nextcloud/calendar#4098 for details

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
tcitworld added a commit that referenced this pull request Feb 9, 2023
…n the current calendar is in the trashbin

Follow-up to #32361, see nextcloud/calendar#4098 for details

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: caldav Related to CalDAV internals
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants