Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose display name cache trough a public interface #32461

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

icewind1991
Copy link
Member

Allows apps to get the display name in the more optimized way.

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 17, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone May 17, 2022
@icewind1991 icewind1991 requested review from a team, blizzz, juliushaertl and CarlSchwan and removed request for a team May 17, 2022 13:22
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense

lib/private/Files/View.php Show resolved Hide resolved
Signed-off-by: Robin Appelman <robin@icewind.nl>
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

@icewind1991 please resolve the conflict

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan merged commit 604c175 into master Aug 16, 2022
@CarlSchwan CarlSchwan deleted the display-name-cache-public branch August 16, 2022 09:48
@CarlSchwan
Copy link
Member

Using it in nextcloud/spreed#7750 for some big performance improvements ;)

@nickvergessen
Copy link
Member

Please add to #32117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants