Cleanup admin delegation setting page #32501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CarlSchwan
commented
May 19, 2022
CarlSchwan
commented
- Simplify code a bit
- Add link to doc
- Use Nextcloud vue component a bit more
- Simplify code a bit - Add link to doc - Use Nextcloud vue component a bit more Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
requested review from
artonge,
skjnldsv and
szaimen
and removed request for
a team
skjnldsv
approved these changes
May 20, 2022
Pytal
approved these changes
May 20, 2022
|
|
Yeah due to an issue in lib/private/Preview/Generator.php this is already fixed in master. I will merge it without rebase so that I don't need to wait 2 hours for the ci 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.