Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add api to register setup checks #32550

Merged
merged 24 commits into from
Oct 19, 2023
Merged

Add api to register setup checks #32550

merged 24 commits into from
Oct 19, 2023

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented May 23, 2022 •
edited by come-nc
Loading

Add an API for applications to register setup checks.
Rework setup checks UI.

@CarlSchwan CarlSchwan requested a review from come-nc May 23, 2022 08:53
@CarlSchwan CarlSchwan self-assigned this May 23, 2022
@CarlSchwan CarlSchwan marked this pull request as draft May 23, 2022 08:53
@kesselb
Copy link
Contributor

kesselb commented Dec 17, 2022

I like the idea 👍

Hopefully, we manage to finish this time #22527 🙈

@come-nc come-nc assigned come-nc and unassigned CarlSchwan Jan 24, 2023
@kesselb kesselb mentioned this pull request Jun 6, 2023
Open
@come-nc come-nc added this to the Nextcloud 28 milestone Sep 28, 2023
@come-nc come-nc force-pushed the feat/api-cleanup-check branch 2 times, most recently from bd23116 to f2f4b84 Compare October 2, 2023 09:35
@come-nc
Copy link
Contributor

come-nc commented Oct 2, 2023

/compile /

@come-nc come-nc mentioned this pull request Oct 9, 2023
Closed
8 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 9, 2023
View reviewed changes
apps/settings/lib/Controller/CheckSetupController.php Fixed Show fixed Hide fixed
apps/settings/lib/Controller/CheckSetupController.php Fixed Show fixed Hide fixed
apps/settings/lib/Controller/CheckSetupController.php Fixed Show fixed Hide fixed
apps/settings/lib/Controller/CheckSetupController.php Fixed Show fixed Hide fixed
lib/private/Server.php Fixed Show fixed Hide fixed
lib/private/Server.php Fixed Show fixed Hide fixed
lib/private/SetupCheck/SetupCheckManager.php Fixed Show fixed Hide fixed
apps/settings/lib/Controller/CheckSetupController.php
@@ -156,7 +150,8 @@
ITempManager $tempManager,
IManager $manager,
IAppManager $appManager,
IServerContainer $serverContainer
IServerContainer $serverContainer,

Check notice

Code scanning / Psalm

DeprecatedInterface Note

Interface OCP\IServerContainer is marked as deprecated
@come-nc come-nc force-pushed the feat/api-cleanup-check branch 2 times, most recently from cddb318 to bb49141 Compare October 12, 2023 10:11
@come-nc come-nc marked this pull request as ready for review October 12, 2023 10:12
@come-nc
Copy link
Contributor

come-nc commented Oct 12, 2023

I removed the new UI draft from the PR so that we can merge this in its current state.
It’s already a big improvement on the current situation, and I will use follow-up PRs to migrate other setupchecks and improve upon them.

@come-nc come-nc requested review from a team, icewind1991 and Altahrim and removed request for a team October 12, 2023 12:12
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 12, 2023
come-nc and others added 21 commits October 19, 2023 11:43
@come-nc
Fix SetupChecks/LdapInvalidUuids.php
0890012 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix UI and add PhpOutdated check
a3ec716 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix docblock and types for new public API
1202171 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Small cleanups in SetupCheck classes
b41b9cf 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix lint problems in vue files
a56d40c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Move existing setup checks to new API
a4618cf 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix PHPDoc in OCP for new SetupResult class
67e7a26 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate NeedsSystemAddressBookSync to new ISetupCheck API
8bfa093 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate ReadOnlyConfig and DefaultPhoneRegionSet to new API
bec6c0a 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @kesselb
Fix description for SetupChecks/NeedsSystemAddressBookSync
fa3c0e4 
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@come-nc
Merge setupchecks from new API into old UI
05cb141 
This will allow migrating checks to the new API without touching the UI
 for now.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add missing licences and copyright in SetupCheck
5503c4c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Migrate InternetConnectivity check to new API
bd37067 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add OCP interface for SetupCheckManager
efa2dfa 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix tests for setup checks
6bc3e00 
Had to remove tests for migrated checks, we should add tests for each
 SetupCheck class later on.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Remove UI draft
968b82c 
For now we will keep the existing UI and only change the API behind it

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Add debug logging when running setup checks to help with debugging sl…
be11ffd 
…ow results

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Move NeedsSystemAddressBookSync to dav application where it’s registered
6aa6f26 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @Altahrim
Remove useless var in apps/settings/lib/SetupChecks/CheckUserCertific…
11ebf46 
…ates.php

Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
@come-nc
Change SetupResult API to named constructors
2e4d154 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Small code style fix in SetupCheckManager
a3cc3b1 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Fix jsunit tests for SetupChecks
789ff3f 
Tests could be simplified to test generic setup check directly with fake
 data instead of trying to mimic real steps results but for now this
 will do.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit b6c35b3 into master Oct 19, 2023
37 of 40 checks passed
@come-nc come-nc deleted the feat/api-cleanup-check branch October 19, 2023 13:41
@nickvergessen
Copy link
Member

Docs would be cool on this one 😎

@nickvergessen nickvergessen mentioned this pull request Nov 17, 2023
Closed
This was referenced Nov 29, 2023
Open
Closed
@pks-t pks-t mentioned this pull request Jan 5, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@Altahrim Altahrim Altahrim approved these changes

@kesselb kesselb kesselb approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews enhancement feature: settings pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@CarlSchwan @kesselb @come-nc @nickvergessen @ChristophWurst @rakekniven @Altahrim