Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api to register setup checks #32550

Merged
merged 24 commits into from
Oct 19, 2023
Merged

Add api to register setup checks #32550

merged 24 commits into from
Oct 19, 2023

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented May 23, 2022

Add an API for applications to register setup checks.
Rework setup checks UI.

@CarlSchwan CarlSchwan requested a review from come-nc May 23, 2022 08:53
@CarlSchwan CarlSchwan self-assigned this May 23, 2022
@CarlSchwan CarlSchwan marked this pull request as draft May 23, 2022 08:53
@kesselb
Copy link
Contributor

kesselb commented Dec 17, 2022

I like the idea 👍

Hopefully, we manage to finish this time #22527 🙈

@come-nc come-nc force-pushed the feat/api-cleanup-check branch 2 times, most recently from bd23116 to f2f4b84 Compare October 2, 2023 09:35
@come-nc
Copy link
Contributor

come-nc commented Oct 2, 2023

/compile /

lib/private/Server.php Fixed Show fixed Hide fixed
lib/private/Server.php Fixed Show fixed Hide fixed
lib/private/SetupCheck/SetupCheckManager.php Fixed Show fixed Hide fixed
@@ -156,7 +150,8 @@
ITempManager $tempManager,
IManager $manager,
IAppManager $appManager,
IServerContainer $serverContainer
IServerContainer $serverContainer,

Check notice

Code scanning / Psalm

DeprecatedInterface Note

Interface OCP\IServerContainer is marked as deprecated
@come-nc come-nc force-pushed the feat/api-cleanup-check branch 2 times, most recently from cddb318 to bb49141 Compare October 12, 2023 10:11
@come-nc come-nc marked this pull request as ready for review October 12, 2023 10:12
@come-nc
Copy link
Contributor

come-nc commented Oct 12, 2023

I removed the new UI draft from the PR so that we can merge this in its current state.
It’s already a big improvement on the current situation, and I will use follow-up PRs to migrate other setupchecks and improve upon them.

@come-nc come-nc requested review from a team, icewind1991 and Altahrim and removed request for a team October 12, 2023 12:12
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 12, 2023
come-nc and others added 21 commits October 19, 2023 11:43
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
This will allow migrating checks to the new API without touching the UI
 for now.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Had to remove tests for migrated checks, we should add tests for each
 SetupCheck class later on.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
For now we will keep the existing UI and only change the API behind it

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ow results

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ates.php

Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Tests could be simplified to test generic setup check directly with fake
 data instead of trying to mimic real steps results but for now this
 will do.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc merged commit b6c35b3 into master Oct 19, 2023
37 of 40 checks passed
@come-nc come-nc deleted the feat/api-cleanup-check branch October 19, 2023 13:41
@nickvergessen
Copy link
Member

Docs would be cool on this one 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement feature: settings pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants